Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit YAML require for recent Ruby versions #4

Closed
wants to merge 5 commits into from
Closed

Explicit YAML require for recent Ruby versions #4

wants to merge 5 commits into from

Conversation

robsyme
Copy link
Contributor

@robsyme robsyme commented Aug 6, 2013

Hi Michael

It seems that all of the YAML bits break on newish (v2.0.0+) versions of ruby. This should fix that (I think).

@michaelbarton
Copy link
Owner

Thanks for the patch Rob! I've haven't tried ruby 2.0 yet. I'll install
this and take it for a spin.

On 6 August 2013 00:19, Robert Syme notifications@github.com wrote:

Hi Michael

It seems that all of the YAML bits break on newish (v2.0.0+) versions of

ruby. This should fix that (I think).

You can merge this Pull Request by running

git pull https://github.com/robsyme/genomer master

Or view, comment on, or merge it at:

#4
Commit Summary

  • Updated to pull rubygems via https
  • We don't need to track Gemfile.lock
  • For ruby versions > 2.0.0, the Syck YAML implementation is not
    included
  • Do version compare the right way, not the hack way.
  • Fix silly newline

File Changes

Patch Links:

@robsyme
Copy link
Contributor Author

robsyme commented Aug 6, 2013

I didn't know that Ruby 2.0 removed the Syck implementation until I ran genomer. Easy fix though. The relevant doc is http://ruby-doc.org/stdlib-1.9.3/libdoc/yaml/rdoc/YAML.html#label-Syck

@michaelbarton
Copy link
Owner

Hi Rob, I merged in your patch fine but I'm having some problems getting 1.8.7 to work with the latest version of md2man. I'll let you know when I've figured it all out.

@robsyme
Copy link
Contributor Author

robsyme commented Aug 13, 2013

No worries. I'll use my fork until you bump the version on this one.

michaelbarton added a commit that referenced this pull request Aug 13, 2013
Signed-off-by: Michael Barton <mail@michaelbarton.me.uk>
@michaelbarton
Copy link
Owner

All fixed now. Try genomer 0.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants